Browse Source
* ci(semgrep): add translation checks for report labels * refactor: shift report tests to it's own yml path can't be applied on a test id basis * ci: ignore regional report in translation checks [skip ci]develop
Alan
3 years ago
committed by
GitHub
2 changed files with 36 additions and 0 deletions
@ -0,0 +1,15 @@ |
|||||
|
from frappe import _ |
||||
|
|
||||
|
|
||||
|
# ruleid: frappe-missing-translate-function-in-report-python |
||||
|
{"label": "Field Label"} |
||||
|
|
||||
|
# ruleid: frappe-missing-translate-function-in-report-python |
||||
|
dict(label="Field Label") |
||||
|
|
||||
|
|
||||
|
# ok: frappe-missing-translate-function-in-report-python |
||||
|
{"label": _("Field Label")} |
||||
|
|
||||
|
# ok: frappe-missing-translate-function-in-report-python |
||||
|
dict(label=_("Field Label")) |
@ -0,0 +1,21 @@ |
|||||
|
rules: |
||||
|
- id: frappe-missing-translate-function-in-report-python |
||||
|
paths: |
||||
|
include: |
||||
|
- "**/report" |
||||
|
exclude: |
||||
|
- "**/regional" |
||||
|
pattern-either: |
||||
|
- patterns: |
||||
|
- pattern: | |
||||
|
{..., "label": "...", ...} |
||||
|
- pattern-not: | |
||||
|
{..., "label": _("..."), ...} |
||||
|
- patterns: |
||||
|
- pattern: dict(..., label="...", ...) |
||||
|
- pattern-not: dict(..., label=_("..."), ...) |
||||
|
message: | |
||||
|
All user facing text must be wrapped in translate function. Please refer to translation documentation. https://frappeframework.com/docs/user/en/guides/basics/translations |
||||
|
languages: [python] |
||||
|
severity: ERROR |
||||
|
|
Loading…
Reference in new issue