Ankush Menat
6019f60d0a
fix(perf): index creation on voucher_detail_no ( #27866 )
voucher_detail_no is supposed to have an index, it was added on
on_doctype_update function of table, however this function is only
called if DocType itself is updated and `on_update` is called on
DocType. Stock ledger Entry doctype hasn't changed since addition of
this index in function.
Before: Lack of this index was causing full table scan in
get_future_sle_to_fix function. (~50 seconds in a reposting job)
After: Single row is fetched (~0.5 second in full reposting job)
Learnings:
1. Add simple indexes via doctype only
2. For complex indexes always change doctype.json file for it to take
effect.
3 years ago
Deepesh Garg
fabbf68e0e
Merge pull request #27872 from 18alantom/fix-make-billing-address-not-read-only
fix: remove readonly from billing address
3 years ago
18alantom
41fefa356f
fix: remove readonly from billing address
3 years ago
yadavyk
d3d4a3da62
fix: Salary Slip Label fixes ( #27865 )
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
3 years ago
Kenneth Sequeira
90a249527d
fix: update dead links in help_links.js ( #27860 )
3 years ago
mergify[bot]
e85c6e3fc5
fix: SO delivery Date not getting set via data import ( #27862 ) ( #27864 )
* fix: SO delivery Date not getting set via data import
* fix: logic to add delivery dates
* fix: linting issue
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
Co-authored-by: Afshan <afshan13k@gmail.com>
(cherry picked from commit d9a219850a02539f82929b5d5490554835fcde8b)
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
3 years ago
Rohit Waghchaure
dc4206428d
fix: consolidated report not consider company currency
3 years ago
Anuja Pawar
5cc3ea0aa7
fix(Payment Reconciliation): minor ux fixes ( #27779 )
* fix: minor fixes
* fix: Linters check
* fix: sider check
* fix: kept unallocated payment amount hidden in allocation
* fix: removed Add row button from the tables (redundant)
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
3 years ago
Kenneth Sequeira
07c680d7cc
fix: help links for purchase cycle and JV ( #27856 )
3 years ago
Kenneth Sequeira
646fd29f0e
fix: update help links for Sales Invoice page ( #27853 )
3 years ago
rohitwaghchaure
e740fec8d0
Merge pull request #27851 from rohitwaghchaure/option-to-set-size-for-multi-select-dialog
feat: option to set the width for the multi-select dialog box
3 years ago
Rohit Waghchaure
69ffddf747
feat: option to set the width for the multi-select dialog box
3 years ago
Saqib
64c1347d1e
refactor!: remove abbreviation renaming ( #27766 )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
3 years ago
Subin Tom
eaa3614155
fix: patch fix added reload_doctype
3 years ago
Himanshu
951ab9f78f
Merge branch 'develop' into subscription_generation_fix_develop
3 years ago
Chillar Anand
772d4753e7
refactor: Clean up mutable defaults and add CI check ( #27828 )
* refactor: Clean up mutable defaults and add CI check
3 years ago
hrwx
ae657c7e4e
fix: create past invoices
3 years ago
Subin Tom
3ece05a9f7
fix: linters fix
3 years ago
Subin Tom
7114659ecc
fix: improved on_update method, added validation for tax calculation, sandbox mode checks
3 years ago
Sagar Vora
656015d99d
test: use `test_dependencies` instead of duplication
3 years ago
Sagar Vora
fc375c5bde
fix: remove newline
3 years ago
hrwx
0f03b19109
fix: reorder updation of end date
3 years ago
Alan
d4b2471cea
fix: use ceil in case of whole uoms for reorder qty ( #27834 )
* fix: use ceil in case of whole uoms for reorder qty
* fix: cache uom query
3 years ago
Sagar Vora
d36849e4f8
test: optimise `test_component_amount_dependent_on_another_payment_days_based_component` ( #27836 )
3 years ago
Marica
ff7506d4a6
fix: revert "fix: missing link in dashboard missing on SI from DN" ( #27832 )
3 years ago
Marica
2691a15c91
Merge pull request #27360 from FHenry/dev_fix_27359
fix: missing link in dashboard missing on SI from DN
3 years ago
Ankush Menat
35e30bdcaf
ci: fail build if asset bundling fails ( #27820 )
3 years ago
Deepesh Garg
91bf40d692
Merge pull request #27811 from frappe/mergify/bp/develop/pr-27792
fix: COA Importer showing blank validations (backport #27792 )
3 years ago
Afshan
cec66d2d10
fix: removed redundant piece of code ( #27817 )
3 years ago
Deepesh Garg
fee54023a6
Merge branch 'develop' into mergify/bp/develop/pr-27792
3 years ago
Noah Jacob
ae5b2f37b1
Merge pull request #27813 from ankush/maintenance_random_period
fix: ignore random periodicity in validations
3 years ago
mergify[bot]
233bf5dd29
fix: using DN for transfer w/o internal customer (backport #27798 ) (backport #27805 ) ( #27807 )
* fix: using DN for transfer w/o internal customer (backport #27798 ) (#27805 )
* fix: using DN for transfer w/o internal customer (#27798 )
This used to be work before though not "advertised", since a lot of
users have started using it as feature, it can't be broken now.
(cherry picked from commit df1f8fddf6e2f4106c1a2778614ba9a1dc5ff67e)
* fix(ux): use toast instead of popup
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
(cherry picked from commit fa944382c53bdeeb92f2dcc876e2c11ed03e20cc)
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
* fix: resolve conflict
* fix: resolve conflicts
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
3 years ago
Ankush Menat
3d3655ed73
fix: ignore random periodicity in validations
3 years ago
Anupam Kumar
85e23ced05
Merge pull request #27808 from anupamvs/lead-issues
fix: broken lead form actions
3 years ago
Deepesh Garg
a2b5e678fe
fix: Use get_list instead of get_all to avoid perm issues
(cherry picked from commit 9507b2d752a40c0dd9e8b43ae3ef64435457c85e)
3 years ago
Deepesh Garg
020f94532b
fix: COA Importer showing blank validations
(cherry picked from commit 0660d6ed01e0668ce828cf9bae9790aead874233)
3 years ago
Anupam
340859cb3c
fix: broken lead form actions
3 years ago
Noah Jacob
3132dcd94a
fix: batch_no not mapped from PR to Stock Entry ( #27794 )
3 years ago
Deepesh Garg
aa0698078f
Merge pull request #27660 from rtdany10/patch-8
fix: tax rate being overridden in case of 0.00
3 years ago
Noah Jacob
f5e0cad6a1
refactor: updated onboarding cards and tours
3 years ago
Jannat Patel
75d9a4fab4
Merge pull request #27797 from pateljannat/adding-frappe-school-to-readme
3 years ago
Jannat Patel
0223f633dc
Merge branch 'develop' into adding-frappe-school-to-readme
3 years ago
pateljannat
f37e4d52d5
docs: frappe school link in readme
3 years ago
Alan
7da777880b
fix: add (uom, brand) Item details in an Item Price ( #27561 )
* fix: add (uom, brand) and update (uom) Item details in an Item Price
* fix: order of query interpolation args
Co-authored-by: Marica <maricadsouza221197@gmail.com>
* fix: named interpolation, remove item price
* fix: sql error
Co-authored-by: Marica <maricadsouza221197@gmail.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
3 years ago
Ganga Manoj
ad03eb25df
fix: Only calculate first_respone_time if SLA is set ( #27789 )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
3 years ago
Saqib
74c8e7bb97
Merge branch 'develop' into pay-received-amt-fix
3 years ago
Saqib
065a2ce983
fix(asset): expected value after useful life validation ( #27539 )
3 years ago
Deepesh Garg
9d9c97ff41
Merge pull request #27785 from GangaManoj/fix-delete-tdr
fix: Delete linked Transaction Deletion Record docs on deleting company
3 years ago
GangaManoj
38c7e42f0c
fix: Delete linked Transaction Deletion Record docs on deleting company
3 years ago
Alan
5c372202d5
fix: set item uom as stock_uom if it isn't set ( #27623 )
* fix: set item uom as stock_uom if it isn't set
3 years ago